Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add chart action into release #578

Merged

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker July 30, 2024 07:00
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.86%. Comparing base (fc3ee21) to head (f8ceee3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   63.86%   63.86%           
=======================================
  Files         180      180           
  Lines       14100    14100           
=======================================
  Hits         9005     9005           
  Misses       4193     4193           
  Partials      902      902           
Flag Coverage Δ
unit 63.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member Author

/assign @zhujian7 @zhiweiyin318

run: |
mkdir -p release
pushd release
helm package ../deploy/cluster-manager/chart/cluster-manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change the appVersion to the release version

?
if not the helm chart will use the latest images by default.

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
@zhujian7
Copy link
Member

zhujian7 commented Sep 3, 2024

/lgtm
/hold
@zhiweiyin318 PTAL

@zhiweiyin318
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 1fc820a into open-cluster-management-io:main Sep 3, 2024
17 checks passed
@qiujian16 qiujian16 deleted the chart-release branch September 3, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants