-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add chart action into release #578
🌱 Add chart action into release #578
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=======================================
Coverage 63.86% 63.86%
=======================================
Files 180 180
Lines 14100 14100
=======================================
Hits 9005 9005
Misses 4193 4193
Partials 902 902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign @zhujian7 @zhiweiyin318 |
.github/workflows/release.yml
Outdated
run: | | ||
mkdir -p release | ||
pushd release | ||
helm package ../deploy/cluster-manager/chart/cluster-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we change the appVersion to the release version
appVersion: latest |
if not the helm chart will use the latest images by default.
8858ea0
to
6ef9cbe
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
Signed-off-by: Jian Qiu <jqiu@redhat.com>
6ef9cbe
to
f8ceee3
Compare
/lgtm |
/unhold |
1fc820a
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #